[wp-trac] [WordPress Trac] #37285: Shiny Updates: (bug): cancelling the filesystem credentials prevents updating unless you reload

[WordPress Trac]

#37285: Shiny Updates: (bug): cancelling the filesystem credentials prevents
updating unless you reload
-----------------------------+-----------------------------
 Reporter:  DavidAnderson    |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:  trunk
 Severity:  normal           |   Keywords:
  Focuses:                   |
-----------------------------+-----------------------------
 Running on the latest nightly: 4.6-beta1-37961

 Reproducible: every time

 Steps to reproduce:

 1) Set up WordPress, and set permissions to that the 'filesystem
 credentials' dialog will be required when performing theme updates.

 2) Go to /wp-admin/themes.php

 3) Click on "Update now". The filesystem credentials dialog should open.
 "Update now" will turn to "Updating..."

 4) Close the filesystem credentials dialog. "Updating..." will return to
 "Update now".

 5) Click again on "Update now".

 Result: nothing happens.
 Excepted result: filesystem credentials dialog should open again. You can
 only get it back by reloading the page.

 Looking at the code, it seems that the initial click cancels all listeners
 with .off() - and they are never registered again.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37285>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform