[wp-trac] [WordPress Trac] #35473: Remove unused local variable in function comments_template()
WordPress Trac
noreply at wordpress.org
Sat Jan 30 22:12:31 UTC 2016
#35473: Remove unused local variable in function comments_template()
--------------------------+-------------------------
Reporter: Latz | Owner: swissspidy
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 4.5
Component: Comments | Version: 2.2
Severity: normal | Resolution:
Keywords: revert | Focuses:
--------------------------+-------------------------
Comment (by rachelbaker):
In [changeset:"36425"]:
{{{
#!CommitTicketReference repository="" revision="36425"
Comments: Add back `$req` variable in `comments_template()`.
The variables in `comments_template()` should never be assumed to be
unused. This function includes the `comments.php` template file from the
active theme or falls back to `theme-compat/comments.php`. This is why
including a file within a function only brings pain and sorrow.
Reverts r36322.
See #35473.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35473#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list