[wp-trac] [WordPress Trac] #30186: Add plugin icons to plugin list table in update-core.php

[WordPress Trac]

#30186: Add plugin icons to plugin list table in update-core.php
---------------------------------------+---------------------------------
 Reporter:  melchoyce                  |       Owner:  afercia
     Type:  enhancement                |      Status:  assigned
 Priority:  normal                     |   Milestone:  4.5
Component:  Upgrade/Install            |     Version:  4.4
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui, administration
---------------------------------------+---------------------------------

Comment (by paulwilde):

 I've thrown together a patch which also implements these on plugins.php,
 should that also be something to consider.

 A couple of observations:
 - You have to include `wp-admin/includes/plugin-install.php` just to get
 access to the `plugins_api` function. There's a few other places that also
 are doing this just to get access to it. It feels dirty. Maybe it would be
 worth moving that function to a more global file?
 - I've pulled the if statements which sets `$plugin_icon_url` from `wp-
 admin/includes/class-wp-plugins-list-install.php`. This seems to be
 lacking from afercia's patch, so it wouldn't give priority to the SVG, and
 wouldn't include the fallback. Maybe this could be put into a helper
 function so it be used in 3 places? Or maybe the API could output this
 instead as a new key within the `icons` key?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30186#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform