[wp-trac] [WordPress Trac] #16206: Comment text not marked as required
WordPress Trac
noreply at wordpress.org
Mon Jan 25 09:57:09 UTC 2016
#16206: Comment text not marked as required
-------------------------------------------------+-------------------------
Reporter: infected | Owner:
Type: defect (bug) | rianrietveld
Priority: normal | Status: assigned
Component: Comments | Milestone: 4.5
Severity: normal | Version: 3.0.4
Keywords: has-patch 2nd-opinion has- | Resolution:
screenshots | Focuses: ui,
| accessibility
-------------------------------------------------+-------------------------
Comment (by rianrietveld):
Replying to [comment:26 afercia]:
> Thinking maybe it is possible to simplify a bit. Since now the Comment
textarea is always indicated as required, the "required text" should
always be printed out regardless of the `require_name_email` option (in
the backend is "Comment author must fill out name and email "). So when
logged in maybe just append the required text to the `logged_in_as`
string?
Is adding the "required text" default not conflicting with already made
changes in the filters by theme developers?
> Additionally, the required attribute can use the HTML5 syntax depending
on the support for HTML5.
Is this an HTML5/XHTML/HTML4 compliance issue or a code standards
compliance issue?
If it's a code standards compliance issue we should keep
required="required" in whatever the theme is build in.
> Lastly, I'd propose to change the error message for missing required
fields:
> since we shouldn't assume they're just "name" and "email".
Agree on that and think we should address this in a separate ticket.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/16206#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list