[wp-trac] [WordPress Trac] #35557: grunt precommit should run phpunit tests

[WordPress Trac]

#35557: grunt precommit should run phpunit tests
------------------------------+-----------------------------
 Reporter:  ericlewis         |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Future Release
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+-----------------------------

Comment (by ericlewis):

 Replying to [comment:6 jorbin]:

 > I wonder if we should try to refactor some of the stuff from grunt-
 patch-wordpress out that detect the difference between git and svn and use
 that.

 Why not :) I've rolled this logic [https://www.npmjs.com/package/git-or-
 svn into a package]. Feedback welcome there.

 Replying to [comment:7 jorbin]:
 > 1) let's not get rid of the description.  It's valuable if you run
 `grunt --help` to see the description.

 Good point!
 > 2) ` Bail if the svn diff command returned a non-zero exit code.` We
 should pass either `false` or an `Error` object so the task is a failure
 rather then just bailing.

 I added a `grunt.fail.warn()` here instead.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35557#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform