[wp-trac] [WordPress Trac] #35090: Query for comments where post isn't set

[WordPress Trac]

#35090: Query for comments where post isn't set
-----------------------------+---------------------------
 Reporter:  danielbachhuber  |       Owner:  boonebgorges
     Type:  defect (bug)     |      Status:  reopened
 Priority:  high             |   Milestone:  4.5
Component:  Comments         |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:
-----------------------------+---------------------------

Comment (by boonebgorges):

 Replying to [comment:7 ocean90]:
 > [36381] broke the comments list table because we're passing 0 to
 `post_id`, see [source:/trunk/src/wp-admin/includes/class-wp-comments-
 list-table.php?rev=36381&marks=43,130#L43].

 Oy.

 It's trivial to fix the comment list table. But if we're doing something
 like this in core, it's extremely likely that the same technique is used
 extensively throughough the WP universe. This almost certainly means that
 we will not be able to make the change in [36381], and if we want a way to
 query for comments with no post, we'll have to come up with some other way
 of doing it.

 I'll try to take some time to search through the plugin repo to see how
 extensive this kind of thing is. (Namely: either passing `post_id=0` to a
 comment query, or copypasta from the core list table.) In the meantime,
 @ocean90, if you think this merits a revert so that trunk is usable, let
 me know (or be my guest).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35090#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform