[wp-trac] [WordPress Trac] #34891: get_submit_button uses incorrect check for delete class

[WordPress Trac]

#34891: get_submit_button uses incorrect check for delete class
----------------------------+---------------------------------
 Reporter:  rmccue          |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  ui-feedback     |     Focuses:  ui, administration
----------------------------+---------------------------------

Comment (by morganestes):

 Came across this today and wanted to chime in. I also didn't find any
 styles for `.delete` that would apply to this input, but since the
 `'delete' === $type` is always false, the classes applied to the element
 are `button delete` instead of `button-secondary delete`, and ''that''
 could end up affecting the UI.

 However in the case I ran into today, both `.button` and `.button-
 secondary` get the exact same styles applied unless `true` is passed to
 `get_submit_button()` to wrap the input in a `p`, but the only difference
 there is a slight adjustment to `vertical-align`.

 In searching for places that use 'delete' in core, I found only one use:
 in widgets.php ("Clear Inactive Widgets"). I'm assuming this hasn't
 cropped up sooner since that form relies on the `removeinactivewidgets`
 value to trigger its purpose and ignores the classes set.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34891#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform