[wp-trac] [WordPress Trac] #35517: Work around PHP7 php-ssh2 breakage

[WordPress Trac]

#35517: Work around PHP7 php-ssh2 breakage
----------------------------+------------------------------
 Reporter:  dougal          |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Filesystem API  |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  administration
----------------------------+------------------------------

Comment (by dougal):

 Replying to [comment:3 dd32]:
 > I'm rather torn over this. On one hand I want to fix the bug, however,
 the bug is quite clearly in the extension as it didn't get ported to PHP7
 correctly.
 >
 > If usage of PHP7 + SSH was higher, I'd be more inclined to fix this,
 however right now this feels like a wontfix assuming the extension gets
 updated to work properly.

 I can understand that. "Not my circus, not my monkeys". Theoretically, it
 will be a self-correcting problem. And I waffled over whether to file this
 as a bug or an enhancement in the first place. But just as food for
 thought...

 Do we have any numbers on how many servers have `allow_url_fopen` turned
 off? By using the native `libssh2` functions instead of relying on the
 stream wrappers, it might allow a few more systems to function (though I'd
 have to actually turn that setting off and do real testing before I fully
 commit to that idea). I don't know if that would affect enough systems to
 justify the change, though. Especially since it's been stated that overall
 usage of the ssh2 filesystem isn't terribly high in the first place?

 In any case, my patch is working for my own system for now.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35517#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform