[wp-trac] [WordPress Trac] #35579: Customizer panel wrong position if Site Title is empty

WordPress Trac noreply at wordpress.org
Fri Jan 22 18:06:28 UTC 2016


#35579: Customizer panel wrong position if Site Title is empty
--------------------------+-----------------------------
 Reporter:  halftones     |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.5
Component:  Customize     |     Version:  4.0
 Severity:  normal        |  Resolution:
 Keywords:  commit        |     Focuses:  ui, javascript
--------------------------+-----------------------------
Changes (by westonruter):

 * status:  new => accepted
 * focuses:  ui, performance => ui, javascript
 * owner:   => westonruter
 * version:  4.4.1 => 4.0
 * milestone:  Awaiting Review => 4.5
 * keywords:   => commit


Comment:

 Replying to [ticket:35579 halftones]:
 > If "Site Title" option (in "Site Identity" panel) is empty – customizer
 stick to the top – under the "Save & Publish" option

 Yes, absolutely. Good catch. I've also noticed this bug when working on
 #34893 when emptying out the site title. The solution I think is just to
 supply some default text, e.g. “(Untitled)”, when no blogname is present.
 See [attachment:35579.diff].

 > (by the way – why it's "Save&Publish" – there is no "Save" and no
 "Publish" separately – so it's just "Save" I think)

 This came up recently on #35547, and I
 [https://core.trac.wordpress.org/ticket/35547#comment:1 commented] there:

 > In the [https://wordpress.org/plugins/customize-snapshots/ Customize
 Snapshots] plugin, the “Save & Publish” buttons are actually split up into
 two separate buttons, “Save” and “Publish”, where the former serves to
 create a draft and the latter actually makes them live. This plugin is a
 feature plugin to implement aspects of transactions (#30937). This being
 said, the “Save & Publish” buttons may get split up in Core after
 transactions land, and I'm wary to create a new filter for this one button
 right now.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35579#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list