[wp-trac] [WordPress Trac] #35557: grunt precommit should run phpunit tests

WordPress Trac noreply at wordpress.org
Thu Jan 21 12:47:43 UTC 2016


#35557: grunt precommit should run phpunit tests
------------------------------+------------------------------
 Reporter:  ericlewis         |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+------------------------------

Comment (by ericlewis):

 @helen had a great point in that discussion:
 > if i'm making CSS changes i don't want to run [phpunit] tests, but
 that's specific to those commits :)

 Perhaps our precommit task could check what files have been modified and
 decide what should be run. e.g.

 * if css has been modified run `postcss:core`
 * if js has been modified run `browserify`, `jshint:corejs`,
 `uglify:bookmarklet`, and `qunit:compiled`
 * if php has bee modified run `phpunit`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35557#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list