[wp-trac] [WordPress Trac] #35006: Comments sent immediately to Trash for matching keyword blacklist should not generate email notifications

[WordPress Trac]

#35006: Comments sent immediately to Trash for matching keyword blacklist should
not generate email notifications
--------------------------------------------------+---------------------
 Reporter:  scottbrownconsulting                  |       Owner:  jorbin
     Type:  defect (bug)                          |      Status:  closed
 Priority:  normal                                |   Milestone:  4.4.1
Component:  Comments                              |     Version:  4.4
 Severity:  normal                                |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests fixed-major  |     Focuses:
--------------------------------------------------+---------------------

Comment (by dimioorg):

 Comments sent immediately to Trash for  filtered captcha generate email
 notifications. Use Invisible Captchs plugin.
 WP 4.4.1 (at three sites)

 {{{#!php
 <?php
 $ sed -n "1783,1813p" comment.php
 function wp_new_comment_notify_postauthor( $comment_ID ) {
         $comment = get_comment( $comment_ID );

         $maybe_notify = get_option( 'comments_notify' );

         /**
          * Filter whether to send the post author new comment notification
 emails,
          * overriding the site setting.
          *
          * @since 4.4.0
          *
          * @param bool $maybe_notify Whether to notify the post author
 about the new comment.
          * @param int  $comment_ID   The ID of the comment for the
 notification.
          */
         $maybe_notify = apply_filters( 'notify_post_author',
 $maybe_notify, $comment_ID );

         /*
          * wp_notify_postauthor() checks if notifying the author of their
 own comment.
          * By default, it won't, but filters can override this.
          */
         if ( ! $maybe_notify ) {
                 return false;
         }

         // Only send notifications for approved comments.
         if ( ! isset( $comment->comment_approved ) || '1' !=
 $comment->comment_approved ) {
                 return false;
         }

         return wp_notify_postauthor( $comment_ID );
 }
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35006#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform