[wp-trac] [WordPress Trac] #26005: Internal jump links and shift-clicking on links in widgets (to edit) erroneously cause navigation in Customizer preview

[WordPress Trac]

#26005: Internal jump links and shift-clicking on links in widgets (to edit)
erroneously cause navigation in Customizer preview
--------------------------+-------------------------
 Reporter:  afercia       |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.5
Component:  Customize     |     Version:  3.4
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------

Comment (by westonruter):

 [attachment:26005.diff] fixes three things:

 * Only listen for clicks on links that have `href` attributes.
 * Prevent following links clicked in the Customizer if shift key is
 pressed when clicking; this fixes an issue when trying to shift-click on a
 widget or nav menu item (#32681) to focus on the control in the
 Customizer.
 * Prevent following jump links (starting with `#`), but instead scroll
 that element into view.

 Note that the logic here will likely be removed once transactions (#30937)
 and the natural URL is loaded into the iframe (#30028).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26005#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform