[wp-trac] [WordPress Trac] #28436: allowed_themes filter does not pass blog_id

[WordPress Trac]

#28436: allowed_themes filter does not pass blog_id
--------------------------------------+-------------------------
 Reporter:  rmccue                    |       Owner:  jeremyfelt
     Type:  defect (bug)              |      Status:  reviewing
 Priority:  normal                    |   Milestone:  4.5
Component:  Themes                    |     Version:  3.4
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  multisite
--------------------------------------+-------------------------

Comment (by jeremyfelt):

 Almost. :)

 Any naming ideas for `allowed_themes_combined`? I'd like something a
 little less confusing.

 We could use `allowed_themes_network`, but that may be confusing as
 `allowed_themes` will be the legacy filter in
 `WP_Theme::get_allowed_on_network()`.

 Other adjustments in [attachment:28436.4.diff]:
 * There are two return points for the `allowed_themes_site` filter in
 `WP_Theme::get_allowed_on_site()`.
 * The `allowed_themes` filter needs to be on the return of
 `WP_Theme::get_allowed_on_network()` rather than inside the `isset()`
 check, otherwise it will not always fire.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28436#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform