[wp-trac] [WordPress Trac] #25696: Double clicking update on list table inline edit removes row from dom

[WordPress Trac]

#25696: Double clicking update on list table inline edit removes row from dom
-------------------------------------+-----------------------------
 Reporter:  mt8.biz                  |       Owner:  afercia
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.5
Component:  Quick/Bulk Edit          |     Version:  3.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, javascript
-------------------------------------+-----------------------------

Comment (by afercia):

 Refreshed patch, taking care also of Terms and Comments. Some notes:
 - when saving maybe it should just return false instead of using
 `xhr.abort()`
 - should users be allowed to open a new Quick Edit form while a previous
 request has not completed yet? this would be easy to restore, not sure if
 safe
 - removed the `toggle` function, it was used to open the form on double
 click, seems no more used since [9439] and removed in [9726] unless I'm
 missing something
 - the parameter passed to `save()` and `edit()` is always a DOM object so
 calling it `id` is a bit confusing

 > Clicking on another Quick Edit while the request hasn't been completed
 yet or had some sort of error is frustrating: nothing happens.
 Yep, see point 2. Currently, clicking to open a new form won't do
 anything, see below:

 [[Image(https://cldup.com/A5ZYGWuqWz.png)]]

 Theoretically, the whole thing could be refactored in order to allow a row
 to be updated "in the background" when it's closed because users clicked
 on a new Quick Edit link. Not sure it would be so safe and easy to
 implement :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25696#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform