[wp-trac] [WordPress Trac] #34350: Update Backbone to 1.2.3 and Underscore to 1.8.3

WordPress Trac noreply at wordpress.org
Tue Jan 19 15:43:14 UTC 2016


#34350: Update Backbone to 1.2.3 and Underscore to 1.8.3
---------------------------------------+------------------------------
 Reporter:  caseypatrickdriscoll       |       Owner:  adamsilverstein
     Type:  enhancement                |      Status:  assigned
 Priority:  normal                     |   Milestone:  4.5
Component:  External Libraries         |     Version:  4.4
 Severity:  normal                     |  Resolution:
 Keywords:  needs-testing needs-patch  |     Focuses:  javascript
---------------------------------------+------------------------------

Comment (by adamsilverstein):

 > [attachment:34350.6.diff] seems to work, not sure if the function()
 wrapper is really needed here. Using `_.defaults()` like in
 [source:/trunk/src/wp-includes/js/media/views/image-
 details.js?marks=18-26#L15] works too.

 I found the function to be required to extend the prototype events. In my
 testing without this, other buttons on the details pane that fail to work.
 events takes either an object or a function, maybe the function gets
 evaluated later? in any case, if you try switching to not use the function
 I think you will find the events attached to the prototype don't fire. If
 thats not the case, agree that would be cleaner!

 Also, thanks for the build info :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34350#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list