[wp-trac] [WordPress Trac] #34350: Update Backbone to 1.2.3 and Underscore to 1.8.3

[WordPress Trac]

#34350: Update Backbone to 1.2.3 and Underscore to 1.8.3
---------------------------------------+------------------------------
 Reporter:  caseypatrickdriscoll       |       Owner:  adamsilverstein
     Type:  enhancement                |      Status:  assigned
 Priority:  normal                     |   Milestone:  4.5
Component:  External Libraries         |     Version:  4.4
 Severity:  normal                     |  Resolution:
 Keywords:  needs-testing needs-patch  |     Focuses:  javascript
---------------------------------------+------------------------------

Comment (by ocean90):

 Speaking of `grunt precommit`, it fails with [attachment:34350.4.diff]
 applied:

 {{{
 Running "qunit:files" (qunit) task
 Testing tests/qunit/compiled.html
 ............................................................................................................................................................F.
 >> Customize Widgets - widget contents should embed (with widget-added
 event) when section and control expand
 >> Message: Died on test #3     at
 file:///Users/Dominik/Development/WordPress/vagrant/www/wp-
 develop/svn/tests/qunit/vendor/qunit.js:263
 >>     at file:///Users/Dominik/Development/WordPress/vagrant/www/wp-
 develop/svn/tests/qunit/vendor/sinon-qunit.js:61
 >>     at file:///Users/Dominik/Development/WordPress/vagrant/www/wp-
 develop/svn/tests/qunit/wp-admin/js/customize-widgets.js:54
 >>     at file:///Users/Dominik/Development/WordPress/vagrant/www/wp-
 develop/svn/build/wp-includes/js/jquery/jquery.js:3
 >>     at file:///Users/Dominik/Development/WordPress/vagrant/www/wp-
 develop/svn/build/wp-includes/js/jquery/jquery.js:3: Can't find variable:
 sidebars
 >> Actual: null
 >> Expected: undefined
 >> ReferenceError: Can't find variable: sidebars

 Testing tests/qunit/index.html
 ............................................................................................................................................................F.
 >> Customize Widgets - widget contents should embed (with widget-added
 event) when section and control expand
 >> Message: Died on test #3     at
 file:///Users/Dominik/Development/WordPress/vagrant/www/wp-
 develop/svn/tests/qunit/vendor/qunit.js:263
 >>     at file:///Users/Dominik/Development/WordPress/vagrant/www/wp-
 develop/svn/tests/qunit/vendor/sinon-qunit.js:61
 >>     at file:///Users/Dominik/Development/WordPress/vagrant/www/wp-
 develop/svn/tests/qunit/wp-admin/js/customize-widgets.js:54
 >>     at file:///Users/Dominik/Development/WordPress/vagrant/www/wp-
 develop/svn/src/wp-includes/js/jquery/jquery.js:3
 >>     at file:///Users/Dominik/Development/WordPress/vagrant/www/wp-
 develop/svn/src/wp-includes/js/jquery/jquery.js:3: Can't find variable:
 sidebars
 >> Actual: null
 >> Expected: undefined
 >> ReferenceError: Can't find variable: sidebars

 Warning: 2/736 assertions failed (3599ms) Use --force to continue.

 Aborted due to warnings.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34350#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform