[wp-trac] [WordPress Trac] #10377: Comment fields should have max lengths

[WordPress Trac]

#10377: Comment fields should have max lengths
--------------------------------------+--------------------------
 Reporter:  muriloazevedo             |       Owner:  rachelbaker
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  4.5
Component:  Comments                  |     Version:  2.8
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+--------------------------

Comment (by azaozz):

 > broke comments on w.org because $wpdb->get_col_length() is returning
 false and falls back to 255. Looking at upgrade_430_fix_comments() the
 fallback should be 65535.
 > ...the method returns also false in case $wpdb->is_mysql is false.

 Not sure if the default lengths for email, name, URL should be 65525. We
 should be using "sane" values :)

 How about we go back to the idea of having an array with the default
 lengths and override it with the actual lengths from the DB (if we can get
 them)? Something like [/attachment/ticket/10377/10377.7.diff 10377.7.diff]
 (needs to fix the unit tests).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/10377#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform