[wp-trac] [WordPress Trac] #35478: 4.4 Regression on Querying for Comments by Multiple Post Fields

[WordPress Trac]

#35478: 4.4 Regression on Querying for Comments by Multiple Post Fields
------------------------------------------+---------------------------
 Reporter:  chriscct7                     |       Owner:  boonebgorges
     Type:  defect (bug)                  |      Status:  closed
 Priority:  high                          |   Milestone:  4.4.2
Component:  Comments                      |     Version:  4.4
 Severity:  major                         |  Resolution:  fixed
 Keywords:  needs-patch needs-unit-tests  |     Focuses:
------------------------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"36326"]:
 {{{
 #!CommitTicketReference repository="" revision="36326"
 Respect all post-related filters in `WP_Comment_Query`.

 The refactor of `WP_Comment_Query`'s SQL generation in [34542] introduced
 a bug
 that caused only the last post-related filter to be respected in comment
 queries. In other words, if querying for comments using params
 `post_status=draft&post_author=3`, only the last-processed of these params
 would be respected. The current changeset fixes the logic so that these
 clauses
 don't overwrite each other.

 Props chriscct7.
 Fixes #35478.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35478#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform