[wp-trac] [WordPress Trac] #34350: Update Backbone to 1.2.3 and Underscore to 1.8.3
WordPress Trac
noreply at wordpress.org
Fri Jan 15 16:36:56 UTC 2016
#34350: Update Backbone to 1.2.3 and Underscore to 1.8.3
-------------------------------------+------------------------------
Reporter: caseypatrickdriscoll | Owner: adamsilverstein
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.5
Component: External Libraries | Version: 4.4
Severity: normal | Resolution:
Keywords: needs-testing has-patch | Focuses: javascript
-------------------------------------+------------------------------
Comment (by ericlewis):
Updated the diff in attachment:34350.4.diff after r36305.
Replying to [comment:10 adamsilverstein]:
> Can you test this patch to see if it resolves the issues you were seeing
in media? subviews should now get their ready events fired which should
help!
This seems to come and go, but I can still reproduce this. Clicking Add
New in the Media Library does nothing. I see that the
[https://github.com/aaronjorbin/develop.wordpress/blob/37dfbef847bd5f4507b3855c24dd747f534e0c4d/src
/wp-includes/js/media/views/attachments/browser.js#L41 listenTo is
invoked] which should set up event binding, and the
[https://github.com/aaronjorbin/develop.wordpress/blob/37dfbef847bd5f4507b3855c24dd747f534e0c4d/src
/wp-includes/js/media/views/frame/manage.js#L189-L192 clickhandler gets
fired] which triggers the event, but something's getting mucked up in
between.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34350#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list