[wp-trac] [WordPress Trac] #34350: Update Backbone to 1.2.3 and Underscore to 1.8.3

[WordPress Trac]

#34350: Update Backbone to 1.2.3 and Underscore to 1.8.3
-------------------------------------+------------------------------
 Reporter:  caseypatrickdriscoll     |       Owner:  adamsilverstein
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.5
Component:  External Libraries       |     Version:  4.4
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |     Focuses:  javascript
-------------------------------------+------------------------------
Changes (by adamsilverstein):

 * keywords:   => needs-testing has-patch


Comment:

 @ericlewis

 flatten functionality is pretty different in the latest Underscore;

 however: our use is incorrect as _.flatten is designed to work on an
 array, not an object. We were passing it an object and were lucky it even
 worked. We need to address this on our end.

 Grabbing all the values here looks like its the right thing to do, in my
 testing its doing the right thing - returning all of the registered
 subviews. I'd like to see some more testing with all of our wp.backbone
 powered components to make sure nothing else crops up.

 Once we are satisfied that nothing major is broken, lets merge to get some
 wider testing.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34350#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform