[wp-trac] [WordPress Trac] #34350: Update Backbone to 1.2.3
WordPress Trac
noreply at wordpress.org
Thu Jan 14 16:19:18 UTC 2016
#34350: Update Backbone to 1.2.3
----------------------------------+------------------------------
Reporter: caseypatrickdriscoll | Owner: adamsilverstein
Type: enhancement | Status: assigned
Priority: normal | Milestone: Future Release
Component: External Libraries | Version: 4.4
Severity: normal | Resolution:
Keywords: | Focuses: javascript
----------------------------------+------------------------------
Comment (by adamsilverstein):
@ericlewis
In [attachment:34350.3.diff] my only additional change is to extract
values before flattening the array of subviews returned in
`wp.Backbone.Subviews.add` - this fixes the slider not rendering issue:
the ready events where never getting fired in the subviews because `all()`
was returning an empty array.
All the subviews are being added using a blank selector and flatten was
returning an empty array. I'm going to test a few more things: using the
existing versions of bb/us with this change, and tracing what happens in
the older versions: whats changed. I'm guessing Underscore has changed how
its `flatten` works although nothing popped out at me when reviewing the
change logs.
Can you test this patch to see if it resolves the issues you were seeing
in media? subviews should now get their ready events fired which should
help!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34350#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list