[wp-trac] [WordPress Trac] #31025: Searching by 0 (zero produces inconsistent results)

[WordPress Trac]

#31025: Searching by 0 (zero produces inconsistent results)
-------------------------------------------------+-------------------------
 Reporter:  jadpm                                |       Owner:  swissspidy
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.5
Component:  Query                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests good-       |     Focuses:
  first-bug commit                               |  administration
-------------------------------------------------+-------------------------
Changes (by swissspidy):

 * keywords:  has-patch has-unit-tests needs-refresh good-first-bug => has-
     patch has-unit-tests good-first-bug commit


Comment:

 [attachment:31025.2.diff] applies cleanly against trunk again. It enables
 searching for "0" throughout the admin (post types, users, comments,
 plugins).

 Besides that I also added `/* translators: %s: search keywords */`
 comments where missing.

 Also, I found a bug in `WP_Plugins_List_Table::_search_callback` where it
 tries to search in array values instead of strings, throwing some
 warnings. I think that has to do with the recent addition of update
 information from the API to the plugin data (see #35301).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31025#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform