[wp-trac] [WordPress Trac] #35301: list_plugin_updates() performs an API call per plugin item

[WordPress Trac]

#35301: list_plugin_updates() performs an API call per plugin item
-----------------------------+------------------
 Reporter:  dd32             |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.5
Component:  Upgrade/Install  |     Version:  2.9
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+------------------

Comment (by mordauk):

 Replying to [comment:7 dd32]:
 > > I'm almost certain this will break nearly every custom plugin updater
 but I need to test to confirm.
 >
 > That's perfectly acceptable in this case. We can't support plugins which
 hook into the update process through these methods forever. The plugin
 check API is also going to change at some point which will more than
 likely also break all existing custom update providers (although we'd
 attempt not to..)

 Really? Sorry to be blunt, but are you serious? You're telling me that it
 is perfectly acceptable to break the update notifications for thousands of
 commercial plugins. I'm sorry, but in my opinion that is 100% unacceptable
 without exhausting other means first.

 Of course it's not realistic to support custom integrations forever, but
 it is WordPress's responsibility to maintain backwards compatibility as
 best as it can. The `plugins_api` filter has always been the recommended
 and best way to hook into the update process for custom plugin updaters.
 To suddenly say "we don't care, find another way" leaves a really bad
 taste in my mouth. It would be one thing if this was a ticket that had
 been opened 3+ years ago, but this is a two week old ticket. To say this
 kind of change would come at an extreme surprise to a lot of plugin
 developers would be an strong understatement.

 I fully support improving this page and reducing the number of API queries
 that need to happen here, but it ''must'' happen gradually if it's
 something that will break a lot of plugins.

 Now, all that said, luckily this does not appear to break plugins that use
 the `plugins_api`, so everything is fine. I do firmly believe it is still
 important that such flippant responses to potentially wide-spread breakage
 not be dismissed so easily.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35301#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform