[wp-trac] [WordPress Trac] #35192: Comments_clauses filter

[WordPress Trac]

#35192: Comments_clauses filter
--------------------------+--------------------
 Reporter:  firebird75    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.4.2
Component:  Comments      |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------

Comment (by boonebgorges):

 > I guess this is because the hierachy is somehow broken somewhere in the
 functions because I had removed B

 Yeah. This breakage represents a much more significant issue, which is
 that hierarchical comment queries now only work correctly for
 uninterrupted hierarchies. The same thing would likely happen if you
 included B as part of the `comment__not_in` param of `WP_Comment_Query`.
 This is something I didn't think of during 4.4 development, and even now,
 I'm not really sure what the "right" behavior should be. My inkling is
 that, if you specify that you want your comments returned hierarchically,
 you would expect that excluding B would exclude its descendants as well,
 but I could see this going either way. I'm going to open up a separate
 ticket for consideration.

 In the meantime, thanks for sticking with me on this. I'm going to go
 ahead with the current fix for 4.4.2.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35192#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform