[wp-trac] [WordPress Trac] #35175: Page parameter no longer works in wp_list_comments
WordPress Trac
noreply at wordpress.org
Wed Jan 13 03:26:35 UTC 2016
#35175: Page parameter no longer works in wp_list_comments
--------------------------+---------------------------
Reporter: smerriman | Owner: boonebgorges
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 4.4.1
Component: Comments | Version: 4.4
Severity: normal | Resolution: fixed
Keywords: fixed-major | Focuses:
--------------------------+---------------------------
Comment (by boonebgorges):
In [changeset:"36276"]:
{{{
#!CommitTicketReference repository="" revision="36276"
Always respect `$comments` array passed to `wp_list_comments()`.
[36157] fixed a bug whereby `wp_list_comments()` would not properly
recognize
custom pagination arguments. See #35175. However, it inadvertently
introduced
a bug that caused any `$comments` array explicitly passed to the function
to be
ignored, when that array was accompanied by pagination arguments that
differ
from those in `$wp_query`. We address this bug by moving the logic
introduced
in [36157] inside a block that only fires when no `$comments` array has
been
provided to the function.
Props ivankristianto.
Fixes #35356.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35175#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list