[wp-trac] [WordPress Trac] #35356: wp_list_comments ignores $comments parameter

[WordPress Trac]

#35356: wp_list_comments ignores $comments parameter
-------------------------------------+---------------------------
 Reporter:  felser                   |       Owner:  boonebgorges
     Type:  defect (bug)             |      Status:  closed
 Priority:  high                     |   Milestone:  4.4.2
Component:  Comments                 |     Version:  trunk
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------------
Changes (by boonebgorges):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"36276"]:
 {{{
 #!CommitTicketReference repository="" revision="36276"
 Always respect `$comments` array passed to `wp_list_comments()`.

 [36157] fixed a bug whereby `wp_list_comments()` would not properly
 recognize
 custom pagination arguments. See #35175. However, it inadvertently
 introduced
 a bug that caused any `$comments` array explicitly passed to the function
 to be
 ignored, when that array was accompanied by pagination arguments that
 differ
 from those in `$wp_query`. We address this bug by moving the logic
 introduced
 in [36157] inside a block that only fires when no `$comments` array has
 been
 provided to the function.

 Props ivankristianto.
 Fixes #35356.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35356#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform