[wp-trac] [WordPress Trac] #35405: Bug with lightbox-gallery

[WordPress Trac]

#35405: Bug with lightbox-gallery
--------------------------+----------------------
 Reporter:  m266          |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Gallery       |     Version:  4.4
 Severity:  normal        |  Resolution:  invalid
 Keywords:                |     Focuses:
--------------------------+----------------------
Changes (by Clorith):

 * status:  new => closed
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 Hi, and welcome to Trac!

 In this situation, we actually need the `rel` attribute to be a part of
 the variable, as you can see on line 130 we use the `$rel` variable
 directly:

 `$html = '<a href="' . esc_attr($url) . "\"$rel>$html</a>";`

 Since we output it here, we expect it to contain the `rel` attribute tag,
 as well as the content of the tag.

 The adjustment mentioned in #34826 changes it so we send the values that
 would make the `else` part trigger.

 If you are experiencing the double `rel` attributes still, I'd recommend
 trying to clear your local cache first, as it may just be something
 sticking around locally, but of course if you continue to experience it do
 follow up on this ticket and we'll be happy to revisit it with you.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35405#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform