[wp-trac] [WordPress Trac] #25696: Double clicking update on list table inline edit removes row from dom

[WordPress Trac]

#25696: Double clicking update on list table inline edit removes row from dom
-------------------------------------+-----------------------------
 Reporter:  mt8.biz                  |       Owner:  afercia
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.5
Component:  Quick/Bulk Edit          |     Version:  3.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, javascript
-------------------------------------+-----------------------------
Changes (by afercia):

 * keywords:  has-patch needs-testing needs-refresh => has-patch needs-
               testing
 * owner:   => afercia
 * focuses:   => ui, javascript
 * status:  new => assigned
 * milestone:  Awaiting Review => 4.5


Comment:

 I'd propose a new approach, similar to what is used in `heartbeat.js`
 (actually `heartbeat.js` has two ways to handle this). Basically aborting
 the AJAX request if any previous one has not completed yet would solve the
 double click (and double Enter) issue. The same approach can be used to
 fix #12769.

 The attached patch is for testing only for now, and focuses only on
 `inline-edit-post.js`. If OK, the same thing should be done for `inline-
 edit-tax.js`. Have to check comments yet.

 Any feedback would be greatly appreciated, cc @azaozz :)

 Note: the simpler way to reproduce this is:
 - Quick Edit a post
 - place the cursor on any input field or textarea, focus a select or check
 a checkbox
 - quickly press "Enter" twice
 - after saving, the Quick Edit form closes and the table row disappears

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25696#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform