[wp-trac] [WordPress Trac] #35337: Global $post is null in "comment_post" and "pre_comment_on_post" hooks
WordPress Trac
noreply at wordpress.org
Mon Jan 11 02:51:48 UTC 2016
#35337: Global $post is null in "comment_post" and "pre_comment_on_post" hooks
--------------------------+--------------------------
Reporter: dennis_f | Owner: johnbillion
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 4.4.2
Component: Comments | Version: 4.4
Severity: normal | Resolution:
Keywords: 2nd-opinion | Focuses:
--------------------------+--------------------------
Changes (by johnbillion):
* keywords: needs-patch => 2nd-opinion
Comment:
It's worth noting that relying on the global `$post` object during the
`comment_post` filter is not reliable anyway, because
[https://core.trac.wordpress.org/browser/tags/4.4.1/src/wp-admin/includes
/ajax-actions.php?marks=981#L973 it's not globalised when a comment is
submitted via an AJAX reply in the admin area].
For the above reason, I'm inclined to wontfix this, unless I'm mistaken or
there's another reason to globalise `$post` or any other variables inside
`wp_handle_comment_submission()`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35337#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list