[wp-trac] [WordPress Trac] #35378: Incorrect comment ordering when comment threading is turned off

[WordPress Trac]

#35378: Incorrect comment ordering when comment threading is turned off
--------------------------+---------------------------
 Reporter:  jmdodd        |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.4.2
Component:  Comments      |     Version:  4.4
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:  template
--------------------------+---------------------------
Changes (by boonebgorges):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"36226"]:
 {{{
 #!CommitTicketReference repository="" revision="36226"
 In `comments_template()`, don't run hierarchical queries if comment
 threading is disabled.

 When hierarchical=true, `WP_Comment_Query` will always fetch comments
 according
 to the comment hierarchy, even if 'thread_comments' is disabled for the
 site.
 This can cause problems when comment threading is disabled after threaded
 comments have been recorded on the site; comments will no longer be
 returned in
 a strictly chronological order.

 We address the issue by refraining from querying hierarchically when
 comment
 threading is disabled.

 Props jmdodd.
 Fixes #35378.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35378#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform