[wp-trac] [WordPress Trac] #35320: Customizer closes when you activate a new theme

WordPress Trac noreply at wordpress.org
Wed Jan 6 05:26:52 UTC 2016


#35320: Customizer closes when you activate a new theme
-------------------------+------------------------------
 Reporter:  melchoyce    |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Customize    |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:
-------------------------+------------------------------
Changes (by westonruter):

 * type:  defect (bug) => enhancement


Comment:

 This functionality was specifically developed for the Customizer:

 {{{#!js
                 /*
                  * When activated, let the loader handle redirecting the
 page.
                  * If no loader exists, redirect the page ourselves (if a
 url exists).
                  */
                 api.bind( 'activated', function() {
                         if ( parent.targetWindow() )
                                 parent.send( 'activated',
 api.settings.url.activated );
                         else if ( api.settings.url.activated )
                                 window.location =
 api.settings.url.activated;
                 });
 }}}

 This has been in place since the Customizer was initially introduced in
 3.4. Looking back in the source, I see it was implemented for #20743. The
 ticket doesn't have much of a rationale for why this behavior was needed.

 In any case, I think the current behavior is not a bug but a feature
 (literally). However, the Customizer may have outlived this feature and it
 may no longer be applicable.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35320#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list