[wp-trac] [WordPress Trac] #35075: Comment cache ignores custom query vars

[WordPress Trac]

#35075: Comment cache ignores custom query vars
-----------------------------+--------------------------
 Reporter:  jason_the_adams  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.5
Component:  Comments         |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:  performance
-----------------------------+--------------------------

Comment (by jason_the_adams):

 Seems like any protection of the `->query_vars` should happen higher up
 the chain, not at the point of caching. I'd like to believe the
 `->query_vars` aren't being arbitrarily injected with the `$_GET`
 superglobal. I dug around and I'm not seeing, at least for comments,
 anywhere that this would be happening. The query string itself is never
 being passed to get_comments.

 Should I throw together a patch that removes the restrictions and caches
 the entire array for comments, taxonomies, and pages?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35075#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform