[wp-trac] [WordPress Trac] #26396: Implement a generic clearfix

WordPress Trac noreply at wordpress.org
Tue Jan 5 01:25:46 UTC 2016


#26396: Implement a generic clearfix
----------------------------+-----------------------
 Reporter:  helen           |       Owner:  afercia
     Type:  enhancement     |      Status:  assigned
 Priority:  low             |   Milestone:  4.5
Component:  Administration  |     Version:  4.4
 Severity:  minor           |  Resolution:
 Keywords:  needs-patch     |     Focuses:  ui
----------------------------+-----------------------

Comment (by michaelarestad):

 Replying to [comment:14 afercia]:
 > Thinking it would be better to start using the new CSS class in the
 cleanest possible way so what about something like
 [attachment:26396.3.patch] where:
 > - Tabs output by core will use `wp-clearfix`
 > - Tabs output by plugins will fallback to a slightly less-ideal clearfix
 method `overflow: hidden`

 I generally stay away from `overflow: hidden` because it could have
 unexpected results. I'm not sure we get a clear benefit from doing this
 other than completely separating the clearfix. My preference would be to
 either duplicate the clearfix to keep the clearfix class separate from
 other classes or just go with something like [attachment:26396.2.patch].

 I lean toward the duplication of rules. I'm also wondering if we should
 start separating out utility classes like `wp-clearfix` from `common.css`
 into their own file.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26396#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list