[wp-trac] [WordPress Trac] #34945: HTTPS website with HTTP images

[WordPress Trac]

#34945: HTTPS website with HTTP images
--------------------------------------------+--------------------------
 Reporter:  Angristan                       |       Owner:  johnbillion
     Type:  defect (bug)                    |      Status:  reopened
 Priority:  normal                          |   Milestone:  4.4.2
Component:  Media                           |     Version:  4.4
 Severity:  normal                          |  Resolution:
 Keywords:  https has-patch has-unit-tests  |     Focuses:
--------------------------------------------+--------------------------

Comment (by azaozz):

 I am 50/50 on this for 4.4.x. On one hand it would have been nice to match
 the code in `wp_get_attachment_url()`. In practice part of
 `wp_calculate_image_srcset()` is quite similar to
 `wp_get_attachment_url()` but faster and gets the URLs for all image
 sizes.

 On the other hand sites that need to switch between http and https or
 support both schemes already have means to correct these URLs
 (`wp_calculate_image_srcset` or another `the_content` filter).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34945#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform