[wp-trac] [WordPress Trac] #34997: preprocess_comment filter does not contain old user_ID field for user_id, instead it has new user_id field
WordPress Trac
noreply at wordpress.org
Tue Jan 5 00:13:32 UTC 2016
#34997: preprocess_comment filter does not contain old user_ID field for user_id,
instead it has new user_id field
--------------------------+--------------------------
Reporter: cookiesowns | Owner: johnbillion
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 4.4.1
Component: Comments | Version: 4.4
Severity: normal | Resolution:
Keywords: fixed-major | Focuses:
--------------------------+--------------------------
Changes (by cookiesowns):
* status: closed => reopened
* resolution: fixed =>
Comment:
Replying to [comment:11 johnbillion]:
> In [changeset:"36039"]:
> {{{
> #!CommitTicketReference repository="" revision="36039"
> Comments: When a comment is submitted, ensure the `user_ID` element in
the array that's passed to the `preprocess_comment` filter gets populated.
>
> Merges [36038] to the 4.4 branch.
>
> Fixes #34997
> }}}
@johnbillion
I see in your test, you're looking for both user_ID and user_id. However
in the patch for comment.php, you've changed user_id, back to user_ID.
Shouldn't this break the test?
Another thing is, what do we do for users that have already worked-around
this change by looking for user_id, instead of user_ID?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34997#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list