[wp-trac] [WordPress Trac] #30787: Shrinkwrap NPM dependencies

WordPress Trac noreply at wordpress.org
Mon Jan 4 08:38:33 UTC 2016


#30787: Shrinkwrap NPM dependencies
--------------------------------+-----------------------
 Reporter:  jorbin              |       Owner:  nacin
     Type:  enhancement         |      Status:  assigned
 Priority:  normal              |   Milestone:  4.4.1
Component:  Build/Test Tools    |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  2nd-opinion commit  |     Focuses:
--------------------------------+-----------------------

Comment (by netweb):

 Replying to [comment:17 nacin]:
 > Okay, I've generated the following `npm-shrinkwrap.json` using the build
 server. Also note the build server currently runs node 0.10.25 and npm
 1.3.24. Both can change upon request.

 Upgrading the build server to use NodeJS v0.12.x should happen at some
 time per comment:9, I believe per the original
 [https://github.com/postcss/postcss/pull/581 upstream issue] only a notice
 will be shown, functionality shouldn't be affected.

 Not that I saw the above notice in my tests with NodeJS v0.10.33 I did get
 a warning for the `grunt-sass` dependencies:
 * `grunt-sass` -> `node-sass` -> `request` -> `hoek`
 * `WARN engine hoek at 2.16.3: wanted: {"node":">=0.10.40"} (current:
 {"node":"0.10.33","npm":"3.5.1"})`


 Revisiting the upgrading of NodeJS toward the end of the 4.5 cycle when
 the `npm-shrinkwrap.json` will be updated sounds like a plan when some
 more in depth testing/analysis can happen as currently functionality does
 not appear to be an issue despite the NodeJS version warning notices ¯\_(
 ツ)_/¯

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30787#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list