[wp-trac] [WordPress Trac] #35049: Remove title attributes: the Dashboard

[WordPress Trac]

#35049: Remove title attributes: the Dashboard
---------------------------------------+--------------------------------
 Reporter:  afercia                    |       Owner:  afercia
     Type:  defect (bug)               |      Status:  reviewing
 Priority:  normal                     |   Milestone:  4.5
Component:  Administration             |     Version:  4.4
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  ui, accessibility
---------------------------------------+--------------------------------

Comment (by ocean90):

 Feedback on [attachment:35049.3.diff]:

 * src/wp-admin/includes/dashboard.php
   * `$aria_label = sprintf( _nx( '%s comment in moderation', '%s comments
 in moderation', $num_comm->moderated, 'comments' ),
 $moderated_comments_count_i18n );` needs its own translator comment
   * The change to `privacy_on_link_title` filter looks good. It was added
 in [14237]. To be sure you could check some of the privacy plugins.
   * Translator comment "%s: draft title." should be "%s: post title" (No
 periods needed)
   * `_( 'View this comment' )` should be `esc_attr__( 'View this comment'
 )`
   * `sprintf( 'Edit “%s”', $draft_or_post_title )` is missing
 a gettext call, the whole string needs to be escaped for attributes
   * `aria-label="' . sprintf( __( 'Install %s' ), esc_attr( $raw_title ) )
 . '">`: The whole string should be `esc_attr`'ed
   * `'<a href="%1$s">%2$s <span class="screen-reader-
 text">(%3$s)</span></a>',` doesn't need a translators comment
   * `'<a href="%1$s" class="musublink">%2$s <span class="screen-reader-
 text">(%3$s)</span></a>',` doesn't need a translators comment
   * `__( 'Dismiss the browser warning panel' )` should be `esc_attr__(
 'Dismiss the browser warning panel' )`
 * src/wp-admin/index.php
   * `_e( 'Dismiss the welcome panel' );` should be `esc_attr_e( 'Dismiss
 the welcome panel' );`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35049#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform