[wp-trac] [WordPress Trac] #35277: Install/Activate issue: The plugin does not have a valid header.

[WordPress Trac]

#35277: Install/Activate issue: The plugin does not have a valid header.
-------------------------------+------------------------------
 Reporter:  wpweaver           |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Plugins            |     Version:  4.4
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+------------------------------
Changes (by swissspidy):

 * keywords:   => reporter-feedback


Comment:

 > Why does the code in the plugin installer KEEP looking for a new plugin
 header sequence after is has found a valid on in the plugin's root?
 > On the other hand, the Activate action from the Installed Plugins page
 seems to use a DIFFERENT algorithm to get the plugin name, and will
 properly activate the plugin.

 Although it isn't really a best practice and not allowed in the plugin
 directory, multiple plugin files can be bundled in a single directory. For
 example, foo/bar.php and foo/baz.php can both contain valid plugin headers
 and can therefore be activated separately.

 > This report is triggered by the latest version of TGM Plugin Activation
 (2.5.2), a fairly widely used plugin accessory library. For whatever
 reason, TGMPA added a valid looking plugin header into its library file
 which my plugin included in a sub-directory.

 TGMPA has had this plugin header for a long time.

 Per https://wordpress.org/support/topic/the-plugin-does-not-have-a-valid-
 header-99, you were experiencing this with version 1.3.3 of your
 [https://wordpress.org/plugins/show-sliders/ Show Sliders] plugin.
 Correct?

 I just uploaded this version on a local install and didn't experience any
 issues. Are there any specific steps needed to reproduce?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35277#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform