[wp-trac] [WordPress Trac] #8071: Refrain from querying all the comments on a post when paged

[WordPress Trac]

#8071: Refrain from querying all the comments on a post when paged
------------------------------------+---------------------------
 Reporter:  markjaquith             |       Owner:  boonebgorges
     Type:  task (blessed)          |      Status:  closed
 Priority:  normal                  |   Milestone:  4.4
Component:  Comments                |     Version:  2.7
 Severity:  normal                  |  Resolution:  fixed
 Keywords:  dev-feedback has-patch  |     Focuses:
------------------------------------+---------------------------

Comment (by boonebgorges):

 In [changeset:"36158"]:
 {{{
 #!CommitTicketReference repository="" revision="36158"
 Ensure that non-default pagination values work in `wp_list_comments()`.

 Prior to 4.4, it was possible to pass 'page' and 'per_page' values to
 `wp_list_comments()` that do not match the corresponding global query
 vars.
 This ability was lost in 4.4 with the refactor of how
 `comments_template()`
 queries for comments; when the main comment query started fetching only
 the
 comments that ought to appear on a page, instead of all of a post's
 comments,
 it became impossible for the comment walker to select comments
 corresponding to
 custom pagination parameters. See #8071.

 We restore the previous behavior by (a) detecting when a 'page' or
 'per_page'
 parameter has been passed to `wp_list_comments()` that does not match the
 corresponding query vars (so that the desired comments will not be found
 in
 `$wp_query`), and if so, then (b) querying for all of the post's comments
 and
 passing them to the comment walker for pagination, as was the case before
 4.4.

 Merges [36157] to the 4.4 branch.

 Props boonebgorges, smerriman.
 Fixes #35175.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/8071#comment:69>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform