[wp-trac] [WordPress Trac] #35567: New argument `is_embeddable` for `register_post_type()`
WordPress Trac
noreply at wordpress.org
Fri Feb 26 12:01:03 UTC 2016
#35567: New argument `is_embeddable` for `register_post_type()`
-------------------------------------------------+-------------------------
Reporter: pampfelimetten | Owner: bradleyt
Type: enhancement | Status: assigned
Priority: normal | Milestone: Awaiting
Component: Embeds | Review
Severity: normal | Version: 4.4
Keywords: good-first-bug needs-unit-tests | Resolution:
has-patch | Focuses:
-------------------------------------------------+-------------------------
Comment (by bradleyt):
@DrewAPicture Firstly, thank you for your feedback. I have uploaded a new
patch which I think covers most of your points.
Couple of things I have not done:
- I have retained the argument name of `is_embeddable`, until we have
some sort of consensus. How would naming decisions like this usually be
resolved?
- There are still no unit tests. I plan to have a go adding these some
time next week, unless someone else jumps in first. (My preference would
still be for someone with more experience to add the tests, but I am happy
to have a go and see how I get on if needed. )
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35567#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list