[wp-trac] [WordPress Trac] #35954: Prevent test environment contamination when HTTPS related assertions fail

[WordPress Trac]

#35954: Prevent test environment contamination when HTTPS related assertions fail
------------------------------+-----------------
 Reporter:  johnbillion       |      Owner:
     Type:  task (blessed)    |     Status:  new
 Priority:  normal            |  Milestone:  4.5
Component:  Build/Test Tools  |    Version:
 Severity:  normal            |   Keywords:
  Focuses:                    |
------------------------------+-----------------
 Several tests which are related to HTTPS alter the `$_SERVER['HTTPS']`
 variable, but then perform assertions before this value is reset. When
 these assertions fail, it has a knock-on affect for other tests because
 the resets don't occur, and we get cascading failures as a result.

 Ideally we should audit every one of our tests to ensure any environment
 changes (including things such as post type registration, messing with
 other superglobals, etc) only perform their assertions after the resets
 happen, but the HTTPS tests are what I'm focusing on for now.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35954>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform