[wp-trac] [WordPress Trac] #35945: Site Logo: reconsider the `site` terminology in code
WordPress Trac
noreply at wordpress.org
Thu Feb 25 02:45:05 UTC 2016
#35945: Site Logo: reconsider the `site` terminology in code
------------------------------+--------------------------------------
Reporter: celloexpressions | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.5
Component: Customize | Version: trunk
Severity: normal | Keywords: needs-patch dev-feedback
Focuses: |
------------------------------+--------------------------------------
[36698] introduced core support for theme icons, but we're explicitly
calling it a theme setting, not a global or site one. While the visible UI
reflects this, the code does not. This is our opportunity to change that,
but only if we act soon.
Most important is the `add_theme_support` handle. `site_logo` is
misleading there. If we change that, we could also change the usage of
`site` throughout the rest of the feature's functions and variables,
internally and in public APIs.
Since we're introducing a new feature here, it seems wrong to use
different terminology in the UI (Logo) than in the code (Site Logo).
That's typically only something that happens when we're stuck with it for
back-compat.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35945>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list