[wp-trac] [WordPress Trac] #34747: Provide more flexibility for "You are customizing" text

WordPress Trac noreply at wordpress.org
Wed Feb 24 21:24:19 UTC 2016


#34747: Provide more flexibility for "You are customizing" text
-----------------------------+-----------------------------
 Reporter:  danielbachhuber  |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Future Release
Component:  Customize        |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:
-----------------------------+-----------------------------

Comment (by ryankienstra):

 '''Patch That Filters Customizer Description'''

 @danielbachhuber,
 This [https://core.trac.wordpress.org/attachment/ticket/34747/34747.diff
 patch] and an identical GitHub [https://github.com/xwp/wordpress-
 develop/pull/143/files PR] filter the Customizer description, as you
 requested. If there's no description, it doesn't echo the `?` button,
 which displays it.

 '''Question About Filtering Title'''

 It's definitely possible to filter the title. But it looks like it could
 be complex. The title is currently bound to the "blogname" setting at
 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/customize-
 controls.js#L3660 customize-controls.js#L3660]:

 {{{
 title.text( $.trim( setting() ) || api.l10n.untitledBlogName );
 }}}

 This title is updated each time the "blogname" setting is updated in the
 Customizer's "Site Title" control. It's possible to override this. But it
 might not be what everyone expects.

 '''Using content_template() To Filter Description'''
 ''Maybe not yet practical''

 There are some differences between
 [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-
 customize-panel.php#L365 WP_Customize_Panel::content_template()] and the
 panel that's currently echoed in
 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/customize.php#L132 customize.php]. For example,
 [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-
 customize-panel.php#L367 content_template()] doesn't have the id
 `customize-info` that [https://core.trac.wordpress.org/browser/trunk/src
 /wp-admin/customize.php#L132 content_template()] has. And the
 [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-
 customize-panel.php#L368 content_template()] method has a button that the
 current implementation [https://core.trac.wordpress.org/browser/trunk/src
 /wp-admin/customize.php#L133 doesn't have]. So for now, this patch doesn't
 use [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-
 wp-customize-panel.php#L368 content_template()].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34747#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list