[wp-trac] [WordPress Trac] #33755: Add Site Logo to WordPress Core

[WordPress Trac]

#33755: Add Site Logo to WordPress Core
-------------------------------------------------+-------------------------
 Reporter:  fatmedia                             |       Owner:
     Type:  feature request                      |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.5
Component:  Customize                            |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  ux-feedback has-patch needs-testing  |     Focuses:  ui
  needs-unit-tests has-screenshots               |
-------------------------------------------------+-------------------------

Comment (by celloexpressions):

 I feel very strongly about the custom control issue.

 The background control, and really the image control (extending the media
 control), are only there for back-compat. The header image control needs
 to be refactored to extend (or possibly even be) the cropped image
 control, with the core control getting library support to show existing
 options. Site icon and header images both have UI that is very specific to
 the way those controls are interacted with, whereas a logo control UI is
 the same as any image control. With the revisions in my patch, once it's
 cleaned up, there is actually no functional difference - there is nothing
 that would be different about a logo control versus the core media
 control. Therefore, there would be no need for a logo control at all. One
 of the primary use cases for the image control/media control with
 mime_type=image is for logos and other theme-specific images on the site.

 Generally, I feel like the point of having control types that can be
 registered for different instances with different parameters is the
 ability for the vast majority of developers to use core controls when
 creating custom options. Core should try to do this as much as possible as
 well. In this case there is actually no difference between what an image
 control vs. a logo control would look like, so it should definitely use
 the core one. Custom controls are an option that can help when the UX
 needs to be significantly modified, but in this case there's no reason to
 use one.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33755#comment:106>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform