[wp-trac] [WordPress Trac] #33755: Add Site Logo to WordPress Core
WordPress Trac
noreply at wordpress.org
Wed Feb 24 05:00:56 UTC 2016
#33755: Add Site Logo to WordPress Core
-------------------------------------------------+-------------------------
Reporter: fatmedia | Owner:
Type: feature request | Status: reopened
Priority: normal | Milestone: 4.5
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: ux-feedback has-patch needs-testing | Focuses: ui
needs-unit-tests has-screenshots needs- |
refresh |
-------------------------------------------------+-------------------------
Changes (by celloexpressions):
* keywords: ux-feedback has-patch needs-testing needs-unit-tests has-
screenshots =>
ux-feedback has-patch needs-testing needs-unit-tests has-screenshots
needs-refresh
Comment:
I can do a sweep on the technical concerns I had tonight and make the
other update on the patch to do a theme mod. Would try to position it for
a somewhat more conservative approach that can be expanded on during beta
for the more complex changes, part of it definitely couldn't happen before
tomorrow.
As of right now, there isn't anything that I saw in the patch that would
let themes specify a logo size. If it is a theme mod, this would be a good
use case for a cropped-image control, but with logos it's probably more
important for the content creator to dictate the size/aspect ratio and the
theme to need to adapt as needed. I also do think this is only slightly
more convenient as a core theme-supported feature versus recommending to
add an image control. The selective refresh support makes the core theme
feature approach more compelling, though.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33755#comment:100>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list