[wp-trac] [WordPress Trac] #33642: Improve default Imagick compression settings
WordPress Trac
noreply at wordpress.org
Wed Feb 24 00:43:47 UTC 2016
#33642: Improve default Imagick compression settings
-------------------------+------------------------
Reporter: joemcgill | Owner: joemcgill
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.5
Component: Media | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
-------------------------+------------------------
Comment (by mikeschroder):
Thanks @joemcgill!
Took a look at [attachment:33642.3.patch]; some feedback:
- If we're going to have another function for resizes (which I agree is
the cleanest solution), I prefer the naming for `thumbnail_image()`, since
that it is `protected` is already clear, even without a preceding `_`.
- Would like to see `strip_meta()` marked `protected` because there's not
an analogue for GD. We can have a filter for stripping this data, though,
as long as it's clear that it is effective only for Imagick in docs.
- Need feature/function detection for: `unsharpMaskImage()`,
`getImageAlphaChannel()`, `setImageDepth()`, `setInterlaceSchema()`,
`setColorspace()`. Can check in `test()` if the compatibility goes back
as far as 2.2, but safest is to feature check directly in the thumbnailing
function, since these aren't "required" for resizes to work.
- Unless there's a reason I'm missing, I'd prefer to not explicitly set
color space and image depth to arbitrary values. If depth is getting set
higher than the original (which looks to be the case in #30402), then we
can detect and use the same bit depth. Would like to respect the original
image's color profile/space/bit depth whenever possible.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33642#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list