[wp-trac] [WordPress Trac] #35557: grunt precommit should run phpunit tests
WordPress Trac
noreply at wordpress.org
Sun Feb 21 00:32:35 UTC 2016
#35557: grunt precommit should run phpunit tests
------------------------------+------------------
Reporter: ericlewis | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 4.5
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
------------------------------+------------------
Comment (by netweb):
Updated patch [attachment:35557.4.diff] makes a couple of changes:
* Adds a new line to the end of each of the `grunt.log.write` messages, so
if multiple precommit tasks are run each message is on a new line rather
than 1 long line.
* Fixes task `imagemin:core` so it is run whenever each of the 3
(currently) JS, CSS, or PHP precommit tasks are run, previously only would
run if JS files had been modified
* Rejigs the grunt tasks in `enqueueTestingTasksForModifiedFiles` to use
grunt sub task aliases of the `precommit` task, `precommit:core`,
`precommit:js` ,`precommit:css`, and `precommit:php`. This should make any
future tasks changes/additions to the "precommit" workflow a little more
friendly for svn blame and improves readability.
Tested with SVN of both modified and new files with JS, CSS, PHP or
combinations thereof.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35557#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list