[wp-trac] [WordPress Trac] #33755: Add Site Logo to WordPress Core

[WordPress Trac]

#33755: Add Site Logo to WordPress Core
-------------------------------------------------+-------------------------
 Reporter:  fatmedia                             |       Owner:
     Type:  feature request                      |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.5
Component:  Customize                            |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  ux-feedback has-patch needs-testing  |     Focuses:  ui
  needs-unit-tests has-screenshots               |
-------------------------------------------------+-------------------------

Comment (by samuelsidler):

 There seem to be a few objections here. Let me make sure I'm understanding
 them.
 1. "Site logo" doesn't belong in core.
 2. "Site logo" is too confusing when compared to "Site icon."
 3. "Site logo" has not received enough testing (including user testing)
 yet.
 4. "Site logo" should be developed and iterated in a feature plugin before
 inclusion.
 5. The code for "Site logo" is new and might not be high quality.

 I don't really agree any any of these objections, for these reasons:
 1. There's clearly a need/use for site logo as evidenced by the usage it
 receives in Jetpack. Feature use in Jetpack isn't always an indication
 that a feature belongs in core, but given the (positive) reception of the
 site icon feature in 4.3 and similar positive indicators from users who
 want/use site logo, I think in this case it's well-warranted for core.
 2. This is the biggest issue I had initially, but user testing didn't show
 this to be a real issue. We could do some work here to remove any
 remaining confusion (see comment 83), but that shouldn't stop site logo
 from going into core.
 3. So far, there have been (only) a few user tests of site logo, but it
 has also received general user testing in the form of shipping in Jetpack.
 I can't find the comment (perhaps it was in Slack, perhaps I just can't
 find it amid all these other comments), but the Jetpack team noted that
 this feature received very few support requests ''except'' as it related
 to the naming, an issue we're improving by calling it "Logo" instead of
 "Site logo" in the UI. I don't think we've ever had a set minimum for
 users tests of a feature that goes into core (how many did the Customizer
 theme switcher have? how about the "new" Press this?), but two to three
 are usually acceptable, depending on the results.
 4. Features '''do not have to be developed in plugins'''. We have never
 mandated this. While it's certainly preferred in some cases, it's not
 necessary in others. This "requirement" should be case-specific. In this
 specific case, the site logo UI is very similar to site icon (a successful
 core feature) and to Jetpack's site logo feature. No, Jetpack is not a
 "feature plugin for core" but it is a great place to watch features
 progress and decide if they should migrate to core. There is nothing wrong
 with pulling features from Jetpack as we're doing here. Further, features
 in Jetpack see higher usage than any feature plugin we've ever had.
 5. I don't actually see anyone making this explicit argument, but I wanted
 to address it. With core committers developing this feature and reviewing
 code quality, this really shouldn't be an issue. The speed of which
 something is developed does not indicate its quality.

 If there are other objections, I clearly missed them. I think my point
 here is that if site logo is testing well, has a core-approved UI that we
 like, there's no reason to hold it back. I haven't seen evidence to the
 contrary.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33755#comment:84>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform