[wp-trac] [WordPress Trac] #23358: Switch to a usermeta key for email confirmation in Multisite

[WordPress Trac]

#23358: Switch to a usermeta key for email confirmation in Multisite
-----------------------------------+------------------------
 Reporter:  SergeyBiryukov         |       Owner:  ocean90
     Type:  enhancement            |      Status:  accepted
 Priority:  normal                 |   Milestone:  4.5
Component:  Options, Meta APIs     |     Version:  3.0
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  multisite
-----------------------------------+------------------------
Changes (by ocean90):

 * keywords:  has-patch early => has-patch 2nd-opinion


Comment:

 Attached [attachment:23358.5.diff]:

 * IMO we don't have to provide a compat layer for the switch to user meta.
 It's unlikely that users whose options are still in the database are still
 interested in changing their email.
 * But in case a user still wants to change their mail with an old key I've
 added an error message "Error while saving the new email. Please try
 again.".
 * Something for another ticket: Shouldn't the email change links expire
 like password reset links, see [33019]?

 Thoughts?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23358#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform