[wp-trac] [WordPress Trac] #35786: Media Uploads in 4.5 Fail

[WordPress Trac]

#35786: Media Uploads in 4.5 Fail
--------------------------+------------------------------
 Reporter:  Ipstenu       |       Owner:  johnbillion
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by gnotaras):

 > Not sure if this is endemic of a core change or of the plugin itself
 being broken. Seems odd.

 Hi Mika, indeed it seemed very odd, mainly because of the lack of any
 error messages.

 I just did some more testing and I think I've possibly identified the
 cause of the problem.

 The media listing is not loading possibly because the body of the response
 to the ajax request contains the following HTML at the end (checked it in
 firebug's console panel):

 {{{
 <br />
 <b>Notice</b>:  is_comments_popup is <strong>deprecated</strong> since
 version 4.5 with no alternative
  available. in <b>/mywproot/wp-includes/functions.php</b
 > on line <b>3661</b><br />
 }}}

 This is a deprecation warning triggered from
 [https://github.com/WordPress/WordPress/blob/master/wp-
 includes/functions.php#L3656 here]. To confirm it, I set {{{WP_DEBUG}}} to
 {{{false}}} in {{{wp-config.php}}} and then it worked with the ''Query
 Monitor'' plugin enabled.

 The above piece of HTML appears in the ajax response body whenever ''Query
 Monitor'' is activated and {{{WP_DEBUG}}} is enabled.

 A few days ago, the media library was also not loading when the
 ''WordPress Beta Tester'' plugin was active, but I'm not sure this
 happened due to the same problem. However, ''WordPress Beta Tester'' seems
 to work with the recent nightly releases without any issues.

 I hope I wrote this feedback clear enough. If anyone needs more info,
 please feel free to ask.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35786#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform